feat(nifi-cluster-helm): add option to include node ports from external services into webProxyHosts
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al services into `webProxyHosts` This change will add the option to include NodePorts from `clusters.externalServices` with custom hosts list and add them in `NifiCluster` under `webProxyHosts`. This will help in cases where NiFi's UI and API is accessed over the node port services and NiFi needs the `host[:port]` entry present in `nifi.web.proxy.host` in `nifi.properties` Signed-off-by: Umar Hussain <umarhussain.work@gmail.com>
mh013370
reviewed
Jan 3, 2024
mh013370
reviewed
Jan 3, 2024
Co-authored-by: Michael H <86672176+mh013370@users.noreply.github.com>
mh013370
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This change will add the option to include NodePorts from
clusters.externalServiceswith custom hosts list and add them inNifiClusterunderwebProxyHosts.Why?
This will help in cases where NiFi's UI and API is accessed over the node port services and NiFi needs the
host[:port]entry present innifi.web.proxy.hostinnifi.properties. If the host is not listed in the property, then NiFi will complain about host header:Additional context
Checklist