Update login_identity_providers.xml template for 2.0.0-M1 #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
approved these changes
Jan 11, 2024
|
This PR can me merged no impact for older version of NiFi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Update of the
login_identity_providers.xmltemplate, to match the one in 2.0.0-M1.Changed:
to
Why?
<property name="Identity Strategy">{{.LdapConfiguration.IdentityStrategy}}</property>removed because it doesn't make sense to have it when you have<property name="Identity Strategy">{{or .LdapConfiguration.IdentityStrategy "USE_DN"}}</property>. Because if.LdapConfiguration.IdentityStrategyis empty, you will haveUSE_DNotherwise you will have the value of.LdapConfiguration.IdentityStrategy.Checklist