Add parameter context secret update detection #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juldrixx
force-pushed
the
feat/parameter_context_secret_update_detection
branch
from
ea158b0
to
8477495
Compare
|
I prefer this solution to the one implemented in PR 309, it does not require a new Controller and can be easly implemented for the other resources that needs it. |
mh013370
reviewed
Jan 17, 2024
mh013370
reviewed
Jan 17, 2024
|
instead of recommending 10 changes, i'll just let you change |
mh013370
reviewed
Jan 17, 2024
juldrixx
force-pushed
the
feat/parameter_context_secret_update_detection
branch
from
af2ee2c
to
f8fdb40
Compare
mh013370
reviewed
Jan 17, 2024
mh013370
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The operator will look into the
ManagedFieldsof theSecretto retrieve theTimeof the operations and extract the latest to compare it to the one stored in itsStatusto detect the updates.Why?
The operator needs to be able to update sensitive parameter but as Nifi doesn't return their value, the operator needs to detect the update of secret to trigger an update of the corresponding parameter.
Additional context
Checklist