Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed nifi.content.viewer.url property default value #382

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Feb 1, 2024

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

A change of the default value of nifi.content.viewer.url from /nifi-content-viewer/ to ../nifi-content-viewer/.

Why?

Because it's the default based on NiFi documentation.

Additional context

I think /nifi-content-viewer/ is the previous default value but has changed at some point.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx changed the title Patch nifi.content.viewer.url property default value Changed nifi.content.viewer.url property default value Feb 1, 2024
@mh013370
Copy link
Member

mh013370 commented Feb 1, 2024

LGTM - looks like we have this overridden in all of our clusters, too

@juldrixx juldrixx merged commit 2498104 into master Feb 1, 2024
5 checks passed
@juldrixx juldrixx deleted the patch/viewer_url_property branch February 1, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants