Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NifiUser sync logic to reduce api calls on UserGroup endpoint #397

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Mar 6, 2024

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Update of the NifiUser sync logic to reduce the number of API call on the UserGroup endpoint.

Why?

Because if we have a lot of user or node, we will spam NiFi to retrieve the group information.

Additional context

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx requested review from erdrix and mh013370 March 6, 2024 14:24
@mh013370
Copy link
Member

mh013370 commented Mar 7, 2024

I have also noticed these endpoints in particular getting hammered while inspecting NiFi logs. This is a much needed change.

@mh013370
Copy link
Member

mh013370 commented Mar 7, 2024

This looks fine on the surface. I just want to carefully walk through the logic to make sure there aren't unintended consequences. You've tested this, yeah?

@juldrixx
Copy link
Contributor Author

juldrixx commented Mar 7, 2024

This looks fine on the surface. I just want to carefully walk through the logic to make sure there aren't unintended consequences. You've tested this, yeah?

I tested it and it seems to good. But if you want to retry to be sure, you can 😁.

@mh013370
Copy link
Member

After review, i don't see anything glaringly incorrect about this.

@juldrixx juldrixx merged commit b3cf715 into master Mar 13, 2024
5 checks passed
@juldrixx juldrixx deleted the patch/reduce_api_call_user_group branch March 13, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants