Add support for Service traffic policies in external services
#403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
mikejoh
force-pushed
the
add-support-for-svc-traffic-policies
branch
from
a95bad3
to
b836d58
Compare
mh013370
reviewed
Mar 13, 2024
| @@ -95,7 +95,7 @@ This section provides an instructions for running the operator Helm charts with | |||
| Build the image from the current branch. | |||
|
|
|||
| ```bash | |||
| export DOCKER_REPO_BASE={your-docker-repo} | |||
| export DOCKER_REGISTRY_BASE={your-docker-repo} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Support to let users configure
externalTrafficPolicyandinternalTrafficPolicyof external services exposed via theNifiClusterAPI.There's also some minor changes to the documentation that's not related to the changes that this PR adds.
Why?
In some environments and sometimes in advanced use cases, the combination of both of these fields, the
Servicetype and the CNI you use (and specific CNI configuration) requires you to configure these fields.Additional context
N/A
Checklist
To Do