Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifier P548 ('version type') #17

Merged
merged 3 commits into from
Mar 11, 2018
Merged

Conversation

Nudin
Copy link
Collaborator

@Nudin Nudin commented Mar 11, 2018

This addresses first half of #15

@konstin
Copy link
Owner

konstin commented Mar 11, 2018

I don't know what exactly I did when resolving that conflict (The github UI doesn't really tell), but it looks fine to me now.

@konstin
Copy link
Owner

konstin commented Mar 11, 2018

Perfect, I'll merge this then.

@konstin konstin merged commit efd33e5 into konstin:master Mar 11, 2018
@konstin
Copy link
Owner

konstin commented Mar 16, 2018

I've just noticed after this conversation that "stable version" in wikidata actually means "supported version" and not "not-prerelease". I'm therefore reverting that change.

konstin added a commit that referenced this pull request Mar 16, 2018
@Nudin
Copy link
Collaborator Author

Nudin commented Mar 16, 2018

I've just noticed after this conversation that "stable version" in wikidata actually means "supported version" and not "not-prerelease". I'm therefore reverting that change.

Interesting. I have ~1000 software items on my watchlist and most of them use "stable version" also for old stable versions. But it's right to revert this for now, it should be discussed before possible adding it back in – and we should definitely also only add it if there is no P548 set yet. That's my fault.

@konstin
Copy link
Owner

konstin commented Mar 16, 2018

I've wrote a query for checking what values are possible for P548. It seems that this was indeed meant for differentiating between the different stages of prereleases and releases, although obsolete version (Q21683863) and stable version (Q2804309) are suddenly talking about support ranges in their description. This imho a bug in the current wikidata classification. Support for a version would be imho much better expressed by adding an end of life qualifier.

@Nudin
Copy link
Collaborator Author

Nudin commented Mar 16, 2018

Yes, especially if you look at the numbers how often the values are used "obsolete version" is used quite rarely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants