Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deep_merge gem with own implementation #81

Merged
merged 5 commits into from Jan 7, 2019
Merged

Replace deep_merge gem with own implementation #81

merged 5 commits into from Jan 7, 2019

Conversation

kke
Copy link
Contributor

@kke kke commented Dec 31, 2018 •
edited

Fixes #80

The deep_merge gem seems a bit out of date and it monkey-patches the core Hash class and breaks active support's deep_merge while at it.

We're not using any of the more exotic features of deep_merge.

@kke kke added bug Something isn't working enhancement New feature or request labels Dec 31, 2018
jakolehm
jakolehm requested changes Dec 31, 2018
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs specs.

@jakolehm jakolehm merged commit 66b9e65 into master Jan 7, 2019
@jakolehm jakolehm deleted the fix/as_compat branch January 7, 2019 11:07
@kke kke mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kke @jakolehm