Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unresolvable statsd endpoint crashes NodeInfoWorker #2165

Closed
jakolehm opened this issue Apr 18, 2017 · 2 comments
Closed

Unresolvable statsd endpoint crashes NodeInfoWorker #2165

jakolehm opened this issue Apr 18, 2017 · 2 comments
Labels
agent bug
Milestone
1.2.0

Comments

@jakolehm
Copy link
Contributor 

I, [2017-04-17T10:31:56.996052 #1]  INFO -- Kontena::Workers::NodeInfoWorker: exporting stats via statsd to udp://this-does-not-exist.kontena.local:8125
E, [2017-04-17T10:31:56.998093 #1] ERROR -- : Actor crashed!
SocketError: getaddrinfo: Name does not resolve
@jakolehm jakolehm added this to the 1.2.0 milestone Apr 18, 2017
@jakolehm jakolehm mentioned this issue Apr 18, 2017
Merged
@SpComb
Copy link
Contributor

SpComb commented Apr 18, 2017

I'm guessing this has always caused the NodeInfoWorker to crash, but now with the observable, that crash is stopping the other workers from seeing the node info, because it happens before the NodeInfoWorker#update_observable.

@jakolehm
Copy link
Contributor Author

@SpComb yes, now agent is halted if this kind of error occurs. I already refactored stats related bits to a separate actor in #2166 (should be safer and more clear)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent bug
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@jakolehm @SpComb