Move debug output to STDERR #1543

kke · 2016-12-12T11:42:33Z

SpComb · 2016-12-12T11:55:37Z

cli/lib/kontena/cli/common.rb

@@ -12,7 +12,7 @@ module Common

      def logger
        return @logger if @logger
-        @logger = Logger.new(STDOUT)
+        @logger = Logger.new(ENV["DEBUG"] ? STDERR : STDOUT)


Should the Logger just always use STDERR?

SpComb · 2016-12-12T11:56:31Z

Could all of the ENV["DEBUG"] && STDERR.puts(...) be replaced with logger.debug(...), or logger.debug { ... } to keep the lazy evaluation?

SpComb · 2016-12-12T12:01:22Z

cli/lib/kontena/client.rb

@@ -46,7 +46,7 @@ def initialize(api_url, token = nil, options = {})
      uri = URI.parse(@api_url)
      @host = uri.host

-      @logger = Logger.new(STDOUT)
+      @logger = Logger.new(ENV["DEBUG"] ? STDERR : STDOUT)


At least here this can just be STDERR, since there are only logger.debug ... calls in the class?

All the logging should be unified anyways at some point.

timolehto · 2016-12-12T12:08:50Z

Just a thought, but couldn't you just provide an option for outputting the configs to a file instead of stdout i.e. something like: kontena vpn config -f kontena.vpn.config?

kke · 2016-12-12T12:19:18Z

This will also help with piping to other commands when debug=true.

timolehto · 2016-12-12T12:29:21Z

True

Move debug output to STDERR

8fb5013

kke added cli enhancement status/code-review labels Dec 12, 2016

SpComb reviewed Dec 12, 2016

View reviewed changes

kke added this to the 1.0.3 milestone Dec 20, 2016

nevalla modified the milestones: 1.0.3, 1.1.0 Dec 20, 2016

kke merged commit d3c0bb3 into master Jan 18, 2017

kke deleted the feature/debug_to_stderr branch January 18, 2017 08:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move debug output to STDERR #1543

Move debug output to STDERR #1543

kke commented Dec 12, 2016 •

edited

SpComb Dec 12, 2016

SpComb commented Dec 12, 2016 •

edited

SpComb Dec 12, 2016

kke Dec 12, 2016

timolehto commented Dec 12, 2016

kke commented Dec 12, 2016

timolehto commented Dec 12, 2016

Move debug output to STDERR #1543

Move debug output to STDERR #1543

Conversation

kke commented Dec 12, 2016 • edited

SpComb Dec 12, 2016

Choose a reason for hiding this comment

SpComb commented Dec 12, 2016 • edited

SpComb Dec 12, 2016

Choose a reason for hiding this comment

kke Dec 12, 2016

Choose a reason for hiding this comment

timolehto commented Dec 12, 2016

kke commented Dec 12, 2016

timolehto commented Dec 12, 2016

kke commented Dec 12, 2016 •

edited

SpComb commented Dec 12, 2016 •

edited