Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating development.md guide to include step to delete master nodes from local cli config file #1909

Merged
merged 2 commits into from Mar 1, 2017

Conversation

daniel-bytes
Copy link
Contributor

@daniel-bytes daniel-bytes commented Feb 28, 2017

Small fix to developer setup documentation.

At the end of document, when describing how to clean up the local dev environment, I added some notes and script explaining how the .kontena_client.json file may need to be cleaned up as well to prevent issues with previous CLI state being maintained.

DEVELOPMENT.md Outdated
You may also want to remove the cli config file to prevent previous state from causing issues:

```bash
rm $HOME/.kontena_client.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is kontena master rm devmaster not enough? Does it still leave some traces to config file?

Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpComb
Copy link
Contributor

SpComb commented Mar 1, 2017

Please update the PR title to match the actual change. It's what shows up as the git master commit summary, so it's misleading ATM.

@daniel-bytes daniel-bytes changed the title Updating development.md guide to include step to delete cli config Updating development.md guide to include step to delete master nodes from local cli config file Mar 1, 2017
@SpComb SpComb merged commit ca4e180 into master Mar 1, 2017
@SpComb SpComb deleted the fix/update-dev-guide branch March 1, 2017 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants