Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hash-validator to 0.7.1 #2105

Merged
merged 1 commit into from Apr 7, 2017
Merged

Bump hash-validator to 0.7.1 #2105

merged 1 commit into from Apr 7, 2017

Conversation

jnummelin
Copy link
Contributor

@jnummelin jnummelin commented Apr 7, 2017

fixes #2092

After

$ cat ~/code/stacks/volumes/ext-vols.yml 
stack: jussi/redis-ext-vol-no-name
description: Just a simple Redis stack with volume
version: 0.0.1
services:
  redis:
    image: redis:3.2-alpine
    command: redis-server --appendonly yes
    volumes:
      - redis-data:/data

volumes:
  redis-data:
    external: false

$ k stack install ~/code/stacks/volumes/ext-vols.yml 
YAML validation failed! Aborting.

- "/Users/jussi/code/stacks/volumes/ext-vols.yml":
  - volumes:
      redis-data:
        external: is not valid

Copy link
Contributor

@SpComb SpComb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

volumes:
  data:
    external: false
YAML validation failed! Aborting.

- test/volumes-test.yml:
  - volumes:
      data:
        external: is not valid

@SpComb SpComb merged commit 760e5a0 into master Apr 7, 2017
@SpComb SpComb deleted the fix/gh-2092 branch April 7, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.2 Stack volumes explodes with external: false
2 participants