Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server cloud event serializer to use HostNode#to_path as node id #2892

Merged
merged 1 commit into from Oct 2, 2017
Merged

Fix server cloud event serializer to use HostNode#to_path as node id #2892

merged 1 commit into from Oct 2, 2017

Conversation

nevalla
Copy link
Contributor

@nevalla nevalla commented Sep 30, 2017

Fixes #2891

jakolehm
jakolehm approved these changes Sep 30, 2017
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpComb SpComb changed the title Use HostNode#to_path as node id Fix server cloud event serializer to use HostNode#to_path as node id Oct 2, 2017
@SpComb SpComb merged commit 0e43fd3 into master Oct 2, 2017
@SpComb SpComb added this to the 1.4.0 milestone Oct 2, 2017
@SpComb SpComb deleted the fix/use_correnct_id_on_host_node_serializer branch October 2, 2017 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
bug server status/merge
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nevalla @jakolehm @SpComb