Fix e2e app remove spec race on terminating service #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Interesting integration-testing merge strategy :P |
kke
added a commit
that referenced
this pull request
Feb 5, 2018
* Fix failing e2e specs * fix e2e app remove spec race on terminating service (#3245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3243 by hacking the
simple-lbservice to have a 1s stop timeoutThe
simple-lbservice can occasionally take up to 10s to terminate: #3243 (comment)This causes the following
app removespec to fail, which leaves some services behind that also break theservice listspec.