Add dev gems to Gemfile, drop Gemfile.lock from VCS #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rubocop gets updated because of this and causes a lot of failures. Fixing. |
added 2 commits
February 4, 2019 12:35
|
Conflicts... |
|
Confict be gone |
|
Conflict again.. |
|
Conflict away again |
jakolehm
reviewed
Feb 20, 2019
pharos-cluster.gemspec
Outdated
| @@ -49,4 +49,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency "rspec", "~> 3.7" | |||
| spec.add_development_dependency "fakefs", "~> 0.13" | |||
| spec.add_development_dependency "rubocop", "~> 0.57" | |||
| spec.add_development_dependency "irb", "~> 1.0" | |||
|
Back in sync again. |
jakolehm
approved these changes
Feb 27, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ruby 2.6
bundle exec irbfails unless you have irb in the bundle.The gemfile.lock in the repo seems to cause more problems than benefits.
Added byebug while at it.