Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hostname for finding a node when setting labels #369

Merged
merged 4 commits into from May 16, 2018
Merged

Use hostname for finding a node when setting labels #369

merged 4 commits into from May 16, 2018

Conversation

jakolehm
Copy link
Contributor

Fixes #367

@jakolehm jakolehm added the bug Something isn't working label May 15, 2018
@jakolehm jakolehm requested a review from SpComb May 15, 2018 20:22
SpComb
SpComb approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@SpComb SpComb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested to work.

Will need merge with #366

@jakolehm jakolehm added this to the 1.1.0 milestone May 16, 2018
@jakolehm jakolehm merged commit 5796695 into master May 16, 2018
@jakolehm jakolehm deleted the fix/label-node-with-external-cloud-provider branch May 16, 2018 14:22
@jakolehm jakolehm mentioned this pull request May 25, 2018
Merged
@jakolehm jakolehm mentioned this pull request Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpComb SpComb SpComb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakolehm @SpComb