Improve reset logic #826
Merged
Improve reset logic #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakolehm
commented
Nov 22, 2018
kke
reviewed
Nov 22, 2018
kke
reviewed
Nov 22, 2018
lib/pharos/cluster_manager.rb
Outdated
|
|
||
| if drain || delete | ||
| apply_phase(Phases::ConfigureClient, [master_hosts.first], ssh: true, master: master_hosts.first, parallel: false, optional: true) | ||
| if master_hosts.first.master_sort_score == 0 |
There was a problem hiding this comment.
master_hosts.first.checks['api_healthy'] (or a helper method) could be clearer.
jakolehm
force-pushed
the
fix/reset-with-persistent-volumes
branch
from
1f57f8a
to
877ebc9
Compare
|
@kke PTAL |
kke
approved these changes
Nov 22, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #825