-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry kube lock acquire until --schedule-window expires #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing that the new
|
Testing that the
|
Testing that the top-level
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run each scheduled task with a
context.Context
, using the--schedule-window=1h
option to set a deadline for the task execution.Fixes #1:
kube/Lock.Acquire
takes acontext.Context
and times out if the lock is not freed before the context expires.This required re-implementing the
k8s.io/client-go/util/retry/RetryOnConflict
due to a bug with watch timeout errors, which caused the upgrades to run without the lock held in case theAcquire
=>retry
=>wait
timed out: kubernetes/client-go#427Fixes #20: the top-level
Kube.AcquireLock()
retries thekube/Lock.Acquire
until it either succeeds, or the context deadline expires. This also handles the master being down, with crude exponential backoff.