KA-389 Add a GetCodename method to ICodeFirstTypeProvider #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neytus
force-pushed
the
feature/KA-389_Bi-directional_resolving_for_type/codename
branch
from
b8074f8
to
6cb2f0d
Compare
petrsvihlik
suggested changes
Aug 23, 2018
| } | ||
|
|
||
| return TypesDictionary.Keys.First(type => GetCodename(type).Equals(contentType)); |
There was a problem hiding this comment.
wouldn't FirstOrDefault do the trick?
| /// Returns a codename corresponding to the given content type model. | ||
| /// </summary> | ||
| /// <param name="contentType">Content type model.</param> | ||
| string GetCodename(Type contentType); |
There was a problem hiding this comment.
now you can rewrite or maybe even get rid of the ContentTypeExtractor class
There was a problem hiding this comment.
but make sure you keep the tests that check whether the system.type query param is added
Neytus
force-pushed
the
feature/KA-389_Bi-directional_resolving_for_type/codename
branch
2 times, most recently
from
c04db7f
to
593c875
Compare
Neytus
force-pushed
the
feature/KA-389_Bi-directional_resolving_for_type/codename
branch
from
593c875
to
b3c74a0
Compare
vaclavm
suggested changes
Sep 4, 2018
|
|
||
| var codename = _codeFirstModelProvider.TypeProvider.GetCodename(typeof(T)); | ||
|
|
||
| if (!IsAlreadyInParameters(parameters) && codename != null) |
There was a problem hiding this comment.
Performance hint: Switch the check, if codename is null there is no need to check the params.
| return enhancedParameters; | ||
| } | ||
|
|
||
| private static bool IsAlreadyInParameters(IEnumerable<IQueryParameter> parameters) |
There was a problem hiding this comment.
What is in the parameters? Please provide better name, something like IsTypeInParameters().
Neytus
force-pushed
the
feature/KA-389_Bi-directional_resolving_for_type/codename
branch
from
b3c74a0
to
8bbb760
Compare
vaclavm
approved these changes
Sep 4, 2018
petrsvihlik
approved these changes
Sep 4, 2018
petrsvihlik
deleted the
feature/KA-389_Bi-directional_resolving_for_type/codename
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes this issue.
A
GetCodenamemethod signature is introduced to theICodeFirstTypeProviderinterface.Internal ref: KA-389