Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples CI #220

Merged
merged 8 commits into from
Dec 14, 2022
Merged

Fix examples CI #220

merged 8 commits into from
Dec 14, 2022

Conversation

IvanKiral
Copy link
Contributor

@IvanKiral IvanKiral commented Dec 12, 2022 •
edited by Simply007

Motivation

Which issue does this fix? Fixes #219

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral requested a review from a team as a code owner December 12, 2022 08:21
Simply007
Simply007 suggested changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some error i.e. on https://deploy-preview-220--kontent-ai-gatsby-packages.netlify.app/

(also for other examples).

Error in console: Cannot read properties of undefined (reading 'Provider')

@Simply007 Simply007 mentioned this pull request Dec 12, 2022
Closed
@Simply007 Simply007 mentioned this pull request Dec 12, 2022
Closed
5 tasks
@Simply007 Simply007 changed the title change version in nvmrc Fix examples CI Dec 12, 2022
This was referenced Dec 12, 2022
Closed
Closed
Merged
@Simply007 Simply007 self-assigned this Dec 14, 2022
@Simply007 Simply007 self-requested a review December 14, 2022 08:06
@Simply007
Copy link
Contributor

@IvanKiral please review

@Simply007 Simply007 requested review from a team and removed request for Simply007 December 14, 2022 08:06
@Simply007 Simply007 mentioned this pull request Dec 14, 2022
Closed
6 tasks
@IvanKiral
Copy link
Contributor Author

lerna.json still contains yarn as npm client.. also we should discuss upgrade of lerna.. we have version of 3 in dependencies and latest one is the 6

@Simply007
Copy link
Contributor

lerna.json still contains yarn as npm client.. also we should discuss upgrade of lerna.. we have version of 3 in dependencies and latest one is the 6

Fixed in 69244a7

@Simply007 Simply007 merged commit cd2aa44 into master Dec 14, 2022
@Simply007 Simply007 deleted the fix-version branch December 14, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simply007 Simply007 Simply007 requested changes

Assignees

@Simply007 Simply007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build and Netlify deployments failing
2 participants
@IvanKiral @Simply007