Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display_timezone support to dateTime element #228

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

kszot-ref
Copy link
Contributor

Motivation

A new feature was added on kontent-ai side - support for timezones (https://portal.productboard.com/kontent/2-kontent-ai-public-roadmap/c/176-configure-timezones-when-working-with-date-and-time-element). By default the "value" field contains the UTC time, but REST API now also stores a new field called "display_timezone", which should contain a timezone string.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added (updated snapshots)
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

@kszot-ref kszot-ref requested a review from a team as a code owner December 21, 2022 14:03
@IvanKiral
Copy link
Contributor

Hey, thanks for the PR :) There is a planned migration to the Gatsby 5. Would you like to have this PR already in v4 or is it enough to have it in v5?

@kszot-ref
Copy link
Contributor Author

Hey, ideally I'd like it included in v4, but v5 would be fine as well.

@Simply007
Copy link
Contributor

Hey, ideally I'd like it included in v4, but v5 would be fine as well.

Hello @kszot-ref,

I think we can include this feature into the v4 supported package and release it as a minor version as the last and then we move on with v5 supported and release a new major version of gatsby packages.

Would it be possible to rebase your PR to resolve the conflicts? I have merged the prior feature requests - asset renditions #215.

@kszot-ref
Copy link
Contributor Author

Hi @Simply007,

I've updated my branch - squashed the changes into a single commit and rebased it against your master branch

Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @kszot-ref!

I went through and everything is in place. I will approve this one and push the example in a separate PR.

@Simply007 Simply007 merged commit 2d01796 into kontent-ai:master Jan 11, 2023
@Simply007 Simply007 mentioned this pull request Jan 11, 2023
5 tasks
@Simply007
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants