Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test slices #232

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Test slices #232

merged 3 commits into from
Jan 24, 2023

Conversation

IvanKiral
Copy link
Contributor

@IvanKiral IvanKiral commented Jan 18, 2023

Motivation

Which issue does this fix? Internal like - DEVREL-734

Showcase the usage of Slice API in the site project. Created a new component called footer.js and added creating slices in gatsby-node.js

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral requested a review from a team as a code owner January 18, 2023 11:01
@Simply007 Simply007 self-requested a review January 23, 2023 13:10
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have extracted the layout into a separate component.

The readme itself looks consistent.

@IvanKiral IvanKiral merged commit 98c146d into master Jan 24, 2023
@IvanKiral IvanKiral deleted the test_slices branch January 24, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants