Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #127

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

connyduck
Copy link
Contributor

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

@Simply007
Copy link
Contributor

Hello @connyduck,

sorry for the delay. Took a while until I caught up after Christmas break.

I need to check that Java 8+ is still supported. Did you have any particular reason for the update?

@connyduck
Copy link
Contributor Author

No particular reason, just noticed when upgrading my own dependencies that yours are out of date as well

@Simply007
Copy link
Contributor

@connyduck, I must apologize. I have completely forgotten about this pull request😞

I have checked the pull requests and it looks OK.

For later reference why 'com.google.guava:guava:23.0 changed to com.google.guava:guava:24.1-jre because they changed version conventions: https://github.com/google/guava/releases/tag/v23.1

@Simply007 Simply007 merged commit e8c7ca5 into kontent-ai:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants