Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve nested mappings #129

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Resolve nested mappings #129

wants to merge 6 commits into from

Conversation

Simply007
Copy link
Contributor

Motivation

This might help with #128.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Test have been created.

TODO:

  • Circular dependency validity
  • Double check all possible mapping and extend testGetStronglyTypedItem to check actual expected object structure

Simply007
Simply007 commented Feb 2, 2021
View reviewed changes
kontent-delivery/src/test/java/kentico/kontent/delivery/nestedmodels/Page.java

// Custom strongly type mapping to List
@ContentItemMapping("sections")
List<Section> sections;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • - extend tests for Map/All linked items/... as is is in ListItem

@Simply007 Simply007 mentioned this pull request Feb 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanKiral IvanKiral Awaiting requested review from IvanKiral IvanKiral will be requested when the pull request is marked ready for review IvanKiral is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Simply007