KCL-6857 Move configuration UI to new design #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrSvirak
approved these changes
May 27, 2021
There was a problem hiding this comment.
All suggestions from the original #123 seem addressed and change looks sound 👍
PetrSvirak
force-pushed
the
KCL-6857_move_ui_to_new_design
branch
from
ada71ea
to
cd4e858
Compare
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=========================================
+ Coverage 8.80% 9.04% +0.23%
=========================================
Files 64 64
Lines 988 962 -26
Branches 40 38 -2
=========================================
Hits 87 87
+ Misses 899 873 -26
Partials 2 2
Continue to review full report at Codecov.
|
Simply007
approved these changes
Jun 4, 2021
5 tasks
Simply007
added a commit
that referenced
this pull request
Feb 28, 2022
Simply007
added a commit
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved configuration UI to new design + did some code cleanup