Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated (UNSAVE_) methods in ContactMap component #117

Closed
Simply007 opened this issue Oct 24, 2018 · 1 comment · Fixed by #118
Closed

Remove deprecated (UNSAVE_) methods in ContactMap component #117

Simply007 opened this issue Oct 24, 2018 · 1 comment · Fixed by #118
Labels
enhancement groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted refactoring up-for-grabs

Comments

@Simply007
Copy link
Contributor

Simply007 commented Oct 24, 2018

Motivation

As a followup for issue #97, there is one component left with lifecycle method with prefix UNSAVE. In the react v17, it is required to remove those methods, because they are about to be deleted.

Proposed solution

Use different lifecycle methods as a substitution for the deprecated ones.

There are 2 occurrences of UNSAFE_componentWillUpdate and one of UNSAFE_componentWillReceiveProps.

Additional context

Current features on Contacts page:
If a user clicks on the address on Contacts (/contacts) page, the page is scrolled to the map and the address is focused on the map. Event when switching the languages.

See also related issues #97, #105, #99 for more information.

@Simply007
Copy link
Contributor Author

Hello @andrew-anguiano. I've just sent you an invitation to the project. If you accept it, I'll be able to assign the issue to you to announce the others in the community this issue is already picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted refactoring up-for-grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant