change UNSAFE_componentWillReceiveProps to getDerivedStateFromProps

[shuikang]

Motivation

Which issue does this fix? Fixes #issue number
#97

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

• Code follows coding conventions held in this repo
• Automated tests have been added
• Tests are passing
• Docu has been updated (if applicable)
• Temporary settings (e.g. project ID used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

[Simply007]

I went through the code and you are counting that the language property is initialized in state. But you never initialize it.

This is in all of the components that are working with language propery.

[Simply007]

Hey @boat46450,

See https://hackernoon.com/replacing-componentwillreceiveprops-with-getderivedstatefromprops-c3956f7ce607 for the main idea how to rewrite old livecycle method componentWillReceiveProps to getDerivedStateFromProps.

FYI: There is also another pull request, that is solving this issue and it is close to-be merged #99.
If you run the application - you can see-that it is not even loaded.

When you want to take the issue, it is always better to submit a comment on the issue, and we add you as a collaborator, we could assign the issue to you to prevent this situation.

[Simply007]

@boat46450 - if you need any help or advice, just feel free to ask!

[Simply007]

Hey @boat46450,

closing the pull request due to inactivity. Feel free to open it!

[Simply007]

Hey @boat46450,

we would like to thank you for contributing to Kentico's open-source project. As a sign of our appreciation, we would like to send you some Kentico Developer Community SWAG!

Please fill out your postal address if you are interested.

This comment was automatically generated. If you've submitted more than one pull request, it's OK to fill out the form just once.

Kentico Developer Community

If there’s anything we can do to help, please don’t hesitate to reach out to us at developerscommunity@kentico.com