Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration sample - Shopify #144

Closed
Simply007 opened this issue Sep 24, 2019 · 2 comments
Closed

Update integration sample - Shopify #144

Simply007 opened this issue Sep 24, 2019 · 2 comments
Assignees
@obulaworld
Labels
dependencies Pull requests that update a dependency file groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted refactoring up-for-grabs

Comments

@Simply007
Copy link
Contributor

Brief bug description

After the rebranding from Kentico Cloud to Kentico Kontent there are still some samples that use old naming in branches named samples/*.

Until the end of October endpoint on domain kenticocloud.com stop working and there will be redirect performed:

Expected behavior

Transfer changes made in #140 to the samples/shopify branch

  • Update dependency from kentico-cloud-delivery to @kentico/kontent-delivery
    • adjust the breaking changes
  • Update dependency @chevtek/react-spinners to @simply007org/react-spinners
    • no breaking changes
  • Rename Kentico Cloud to Kentico Kontent
  • adjust travis.yml to use the correct domain for deployment
@Simply007 Simply007 changed the title Update sample configuration - Shopify Update integration sample - Shopify Sep 24, 2019
@Simply007 Simply007 added help wanted refactoring hacktoberfest up-for-grabs groomed The issue has been groomed and should be in a good shape. dependencies Pull requests that update a dependency file labels Sep 24, 2019
@obulaworld
Copy link

Hi @Simply007 , I can work on this.

@Simply007
Copy link
Contributor Author

Simply007 commented Oct 8, 2019 •
edited
Loading

It is yours @obulaworld!

This was referenced Oct 8, 2019
Closed
Closed
@obulaworld obulaworld mentioned this issue Oct 8, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obulaworld obulaworld

Labels
dependencies Pull requests that update a dependency file groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted refactoring up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Simply007 @obulaworld