-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added basic loading spinner to sample app #93
added basic loading spinner to sample app #93
Conversation
This build failed due to the following kontent-ai/delivery-sdk-js#69 Would you be OK with updating to use alpha version of react-scripts? |
Fundamentally, yes. As long as the app remains completely functional. |
@petrsvihlik - project has been updated to use "react-scripts": "^2.0.0-next.a671462c" and is now passing 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one little problem...the rest looks good to me
now it works fine :) thank you for the PR @liamgold ! |
#85 - Had a go at adding a loading spinner for the web service calls.
Used https://www.npmjs.com/package/@chevtek/react-spinners as it has a nice service for toggling the visibility of the spinner across components.