Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetChassisStatusRsp did not handle optional byte in response data #13

Closed
hustbeta opened this issue Feb 17, 2016 · 2 comments
Closed

GetChassisStatusRsp did not handle optional byte in response data #13

hustbeta opened this issue Feb 17, 2016 · 2 comments

Comments

@hustbeta
Copy link

From the ipmi 2.0 spec, 28.2 Get Chassis Status Command, there is an optional extra byte in response data. So the response could be 5 bytes. But GetChassisStatusRsp handles 4 bytes only, which will raise DecodingError('Data has extra bytes'). I have came across this problem on some HP servers, they returned the optional byte as 0x00.

I am not familiar with the source code, maybe appending a RemainingBytes to GetChassisStatusRsp will solve the issue?
@hthiery
Copy link
Contributor

hthiery commented Feb 17, 2016

indeed this extra bytes is not handled.

@hthiery
Copy link
Contributor

hthiery commented Feb 17, 2016

It is fixed by adding "optional" field.

@hthiery hthiery closed this as completed Feb 17, 2016
@FerencFarkasPhD FerencFarkasPhD mentioned this issue Mar 1, 2019
Closed
FerencFarkasPhD added a commit to FerencFarkasPhD/python-ipmi that referenced this issue Mar 20, 2019
@FerencFarkasPhD
Feature enhancement of chassis status
5abc200 
Solving the following two issues:

GetChassisStatusRsp did not handle optional byte in response data kontron#13

Get Chassis Status command kontron#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hustbeta @hthiery