Ренат Зубакин #222
Ренат Зубакин #222
Conversation
|
Все комменты обсуждаемы - можем обсуждать или в тредах, или в личке в телеге На пофикшенные комментарии можно ставить реакции или писать пометочки, что сделал и почему |
| } | ||
|
|
||
| [Test] | ||
| public void PutNextRectangleFirstRectanglePositionEqualCenter() |
There was a problem hiding this comment.
PutNextRectangle_ShouldPlaceFirstOnCenter или что-нибудь такое, чтобы читаемость была лучше
| { | ||
| public class SpiralDistribution : IDistribution | ||
| { | ||
| public Point Center { get; private set; } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| public SpiralDistribution(Point center) | ||
| { | ||
| Center = center; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
throw new ArgumentException(); должен жить на отдельной строчке
There was a problem hiding this comment.
Считаю, что конструктор должен быть максимально простым, никаких проверок внутри не должно быть, его задача - инициализировать объект, если хочешь сделать проверку на входные параметры, то лучше сделать статичный метод который это будет проверять, и потом сам вызовет тебе приватный конструктор,
Ну и декомпозиция, все дела
Да и тесты так как то приятнее писать когда вызываешь какой нибудь метод Create вместо new
Как вариант валидацию выносить в отдельный приватный метод
| [Test] | ||
| public void CircularCloudLayouter_Initialize_Params() | ||
| { | ||
| Assert.AreEqual(0, tagsCloud.WordPositions.Count); |
| } | ||
|
|
||
|
|
||
| private static IEnumerable<TestCaseData> PutNextRectangleIncorrectArguments() |
There was a problem hiding this comment.
Тестовые данные лучше выносить в отдельные файлы ЧетоТамTestData.cs
| public void SetUp() | ||
| { | ||
| drawer = new CloudLayouterDrawer(10); | ||
| fileName = "testcreation.png"; |
There was a problem hiding this comment.
Если строчка не меняется, почему бы ее в константу не унести?
There was a problem hiding this comment.
я нагенерил через цикл с параметрами, что высота может быть больше чем ширина, поэтому их так и покривило
|
Давай придерживаться общепринятого: тред в ревью резолвит тот, кто его создал |
| @@ -0,0 +1,81 @@ | |||
| using System; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| } | ||
|
|
||
|
|
||
| public bool CheckIntersection(Rectangle currRectangle) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| { | ||
| private Random random; | ||
| public int margin; | ||
| public int imageWidth; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| public CloudLayouterDrawer(int margin) | ||
| { | ||
| this.margin= margin; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| } | ||
|
|
||
|
|
||
| public Rectangle ComperessRectangle(Rectangle rectangle) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| var newRectanglesPositions = GetNewRectanglesPositions(rectangles); | ||
|
|
||
| using (var bitmap = new Bitmap(imageWidth, imageHeight)) |
There was a problem hiding this comment.
можно упростить до using var bitmap = new Bitmap(imageWidth, imageHeight)
| public int imageWidth; | ||
| public int imageHeight; | ||
|
|
||
| public CloudLayouterDrawer(int margin) |
There was a problem hiding this comment.
Цвет фона можно сделать параметром рисовальщика
| var brush = new SolidBrush(color); | ||
| graphics.FillRectangle(brush, rectangle); | ||
| } | ||
|
|
There was a problem hiding this comment.
Сохранение в файл отлично декомпозируется в отдельный метод
| } | ||
|
|
||
| [Test] | ||
| public void CloudLayouterDrawer_IsCreate_Imgae() |
| private SpiralDistribution spiralDistribution; | ||
|
|
||
| [SetUp] | ||
| public void SetUp() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| using NUnit.Framework; | ||
| using NUnit.Framework.Interfaces; | ||
|
|
||
| namespace TagsCloudVisualization |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| namespace TagsCloudVisualization | ||
| { | ||
| [TestFixture] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| namespace TagsCloudVisualization.TagsCloudVisualizationTests | ||
| { | ||
| [TestFixture] | ||
| public class SpiralDistributionTests |
There was a problem hiding this comment.
Не хватает тестов на уникальность точек, увеличение радиуса
| } | ||
|
|
||
|
|
||
| private CircularCloudLayouter getRandomTagsCloud() |
There was a problem hiding this comment.
Функции должны называться с больших буков
| { | ||
| var distanceToCenter = | ||
| Math.Sqrt(Math.Pow(tag.X - tagsCloud.Center.X, 2) + Math.Pow(tag.Y - tagsCloud.Center.Y, 2)); | ||
| return distanceToCenter <= GetCircilarCloudLayouterRadius(randomTagsCloud); |
There was a problem hiding this comment.
Раскладка в форме капли тоже отработает в это условие, не?
| { | ||
| public class CloudLayouterDrawer | ||
| { | ||
| private readonly Random random; |
There was a problem hiding this comment.
В одном файле поля и свойства до конструктора, в другом после, как-то уж определись)
| using System.IO; | ||
| using System.Linq; | ||
|
|
||
| namespace TagsCloudVisualization |
|
|
||
| namespace TagsCloudVisualization | ||
| { | ||
| public class CircularCloudLayouter |
| drawer = new CloudLayouterDrawer(10); | ||
| var projectDirectory = Directory.GetParent(Environment.CurrentDirectory).Parent.FullName; | ||
| testFilePath = Path.Combine(projectDirectory, "images", fileName); | ||
| if (File.Exists(testFilePath)) File.Delete(testFilePath); |
| } | ||
|
|
||
| [Test] | ||
| public void SprialDistribution_Initialize__Custom_Params() |
@grantsev