-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text shadow is drawn over text underline #1634
Comments
It looks like a bug. I am not sure yet what will be the easy fix. Thanks for the report! |
Actually, I found it and fixed. I will publish release later. |
Perfect, thanks for the quick fix. I was trying to understand what could be the cause (seems like a drawing order or something since the shadow of the underline doesn't cover itself) but I'm too unfamiliar with the implementation of this library to get far enough. |
Just a quick note, I made some other test and the issue happens also with |
Oh, you are right! I forgot about it. Just added that case too. |
Do you have an ETA for the next release ? |
Let's do it today. |
Done. Please try it with |
This fix does work indeed. |
Hello everyone,
First of all thanks for the library, it works like a charm.
However I've found an issue in a specific case.
When we use
textDecoration: 'underline'
on aText
element and add a shadow to it, the shadow is drawn over the underline instead of under it.Exemple here : https://jsbin.com/rujuzotiqa/edit?html,js,output
The text was updated successfully, but these errors were encountered: