Text shadow is drawn over text underline

[Tom-Aive]

Hello everyone,

First of all thanks for the library, it works like a charm.

However I've found an issue in a specific case.
When we use textDecoration: 'underline' on a Text element and add a shadow to it, the shadow is drawn over the underline instead of under it.

Exemple here : https://jsbin.com/rujuzotiqa/edit?html,js,output

[lavrton]

It looks like a bug. I am not sure yet what will be the easy fix.

Thanks for the report!

[lavrton]

Actually, I found it and fixed. I will publish release later.

[Tom-Aive]

Perfect, thanks for the quick fix.

I was trying to understand what could be the cause (seems like a drawing order or something since the shadow of the underline doesn't cover itself) but I'm too unfamiliar with the implementation of this library to get far enough.

[Tom-Aive]

Just a quick note, I made some other test and the issue happens also with textDecoration: 'line-through'.
So your fix might need to be adjusted if I understand it correctly.

[lavrton]

Oh, you are right! I forgot about it. Just added that case too.

[Tom-Aive]

Do you have an ETA for the next release ?

[lavrton]

Let's do it today.

[lavrton]

Done. Please try it with konva@9.2.1.

[Tom-Aive]

This fix does work indeed.
Thanks for your time !