New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add welcome message when reaching wizard, navigate back to correct place when clicking Cancel #114
Add welcome message when reaching wizard, navigate back to correct place when clicking Cancel #114
Conversation
Skipping CI for Draft Pull Request. |
1e96eb5
to
68c5060
Compare
</QueryClientProvider> | ||
</> | ||
); | ||
} = useRouteMatch<{ namespace: string }>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This little refactor is an artifact of the reverted changes for the from
URL param, but I left it this way because it's still an improvement (useRouteMatch
is less awkward than using the RouteMatch
prop type)
… for the modal or the cancel button
2fb6d9e
to
bacb97e
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibolton336, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #105
Adds the following modal when you reach the import wizard page:
Note: at first we intended to have this modal only appear if you are not coming from the Add page, since the Add page card has a short similar description. To that end I implemented a
?from=
URL parameter that I then reverted when we decided to have it show up no matter the source. If it ever becomes useful later, you can see that implementation in ea5f0c4 . This was also initially used as the method for navigating back to the right place on Cancel, before I realized we can just usehistory.goBack()
.In order to implement the "don't show this again" checkbox, this PR also introduces a new common hook
useLocalStorage
that would be a good contribution to lib-ui later on (see migtools/lib-ui#106). This is a simpler alternative to the LocalStorageContext we implemented in forklift-ui.