New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: tekton and crane ui integration #59
Conversation
bda2de1
to
99d7128
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should consider some approach for versioning on the cluster tasks.
I also believe that we should use the user's oath in some way to have access to the destination cluster rather an trying to rely on an admin user always being present.
Just to copy here: there are a few properties the UI collects (as designed currently) that I don't see how to map to params on the ClusterTasks here for each PVC: migration type (from prior discussion it sounds like this may not be relevant), target storage class name, capacity, and a boolean for whether to verify the copy. Slack discussion: https://coreos.slack.com/archives/C02ELCA262K/p1643662825288189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is a really thorough enhancement and it satisfies our need to get our design thoughts captured so we can begin the implementation. There are several open questions we should document and in some cases defer to follow-on enhancements. Let's just make sure those are all called out, and I will make sure that we have spikes on the roadmap to get those questions answered. Thank you for this @djzager, I learned a lot with the read.
|
||
#### crane-kubectl-scale-down | ||
|
||
The `kubectl-scale-down` ClusterTask is responsible for scaling down the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavgaikwad is this task sufficient to accomplish the abstract idea of "Quiesce"? What does MTC do if they are one-off pods with volumes mounted?
greatest probably of API incompatibilities are from adding/removing parameters | ||
or workspaces from ClusterTasks. | ||
|
||
To help mitigate these risks, whatever container image specified for Crane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an assertion by the pipeline that these are all fall within acceptable and expected versions and it fails fast and loudly with a specific error would be a good thing to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you expand on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough write up, overall it makes a lot of sense.
/lgtm
The purpose of this change is to align with what is described in konveyor/enhancements#59 only to the extent that a demonstration of "Stateless App Migration" is possible. This will likely break our examples so it should not be merged into 'main' until stabilized.
The purpose of this change is to align with what is described in konveyor/enhancements#59 only to the extent that a demonstration of "Stateless App Migration" is possible. This will likely break our examples so it should not be merged into 'main' until stabilized.
* feat: update clustertasks to integrate with UI The purpose of this change is to align with what is described in konveyor/enhancements#59 only to the extent that a demonstration of "Stateless App Migration" is possible. This will likely break our examples so it should not be merged into 'main' until stabilized. * chore: move kustomize manifests to config * chore: update examples based on new paths Now that all of the ClusterTasks have been updated based on [the tekton ui integration enhancement](https://github.com/konveyor/enhancements/tree/master/enhancements/crane-2.0/tekton-ui-integration), and some issues were discovered with handling of defaults, this commit attempts to make all of the changes functional. That means, after this commit all examples should integrate with the ClusterTasks as implemented. * chore: update hack dir * chore: remove personal container image references * docs: update descriptions to be more meaningful
The purpose of this change is to align with what is described in konveyor/enhancements#59 only to the extent that a demonstration of "Stateless App Migration" is possible. This will likely break our examples so it should not be merged into 'main' until stabilized.
The Tekton + Crane UI Integration enhancement.