This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Warn instead of blocking when selecting a storage class with no provisioner #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-381-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
Codecov Report
@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 62.84% 62.87% +0.03%
==========================================
Files 121 121
Lines 3488 3491 +3
Branches 797 798 +1
==========================================
+ Hits 2192 2195 +3
Misses 1279 1279
Partials 17 17
Continue to review full report at Codecov.
|
mturley
force-pushed
the
bz1916178-unblock-storage-classes
branch
from
c2dad85
to
8f20836
Compare
ghost
merged commit 
|
@mturley @fdupont-redhat After checking OpenShift docs, I would like to change the error message slightly. Could we change the first sentence to "This storage does not support dynamic provisioning"? |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1916178