PlanDetails: Refactor using IPlan object

[gildub]

Using generatePlan and generateMappings to create a non resilient IPlan object to feed PlandDetails instead of fields.

[konveyor-preview-bot]

🚀 Deployed Preview: http://konveyor-forklift-ui-pr-620-preview.surge.sh ✨

Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh

[codecov]

Codecov Report

Merging #620 (e5ca157) into main (2e64d3b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   59.23%   59.29%   +0.06%     
==========================================
  Files         144      144              
  Lines        4776     4771       -5     
  Branches     1312     1313       +1     
==========================================
  Hits         2829     2829              
+ Misses       1909     1904       -5     
  Partials       38       38              

Impacted Files	Coverage Δ
src/app/Plans/components/PlanDetails.tsx	83.72% <100.00%> (-1.70%)	⬇️
src/app/Plans/components/PlanDetailsModal.tsx	21.42% <100.00%> (+0.49%)	⬆️
src/app/Plans/components/Wizard/Review.tsx	96.87% <100.00%> (+0.10%)	⬆️
src/app/Plans/components/Wizard/helpers.tsx	92.01% <0.00%> (+1.52%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e64d3b...e5ca157. Read the comment docs.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[mturley]

LGTM, minor comment to address later.

[mturley]

generateMappings won't produce a mapping with a metadata.name field if the wizard has no existing mapping being edited or no new mapping name being entered (instead it will use the generateName field). this as IMetaObjectMeta assertion here prevents TS from catching this. So this name field will be undefined in that case...

However, that doesn't really matter here because the plan.spec.map that is generated here isn't being used at all. So honestly we could just pass { name: '', namespace: '' } for these mapping refs instead. If so we should probably leave a comment explaining that real mappings are not necessary for this ephemeral plan object.

I'm going to merge anyway so I can prevent merge conflicts with #597, but we should probably clean this up later.

[gildub]

@mturley, noted, I've added #627

[mturley]

Thanks!