Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tomcat legacy as a test case for analysis #31

Closed
pranavgaikwad opened this issue Sep 14, 2023 · 4 comments
Closed

Add tomcat legacy as a test case for analysis #31

pranavgaikwad opened this issue Sep 14, 2023 · 4 comments
Assignees

Comments

@pranavgaikwad
Copy link
Contributor

pranavgaikwad commented Sep 14, 2023

https://github.com/konveyor/example-applications/tree/main/example-1

@aufi
Copy link
Member

aufi commented Sep 14, 2023

Seems to be present as tc_tomcat / Tomcate legacy application - https://github.com/konveyor/go-konveyor-tests/blob/b0615a30ee635dad62f898e67fc28ad0f828c188/analysis/tc_tomcat.go

@aufi
Copy link
Member

aufi commented Sep 22, 2023

Test was updated with fixes of incidents line numbers and Tags. Currently expected analysis results is at https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_tackle_testapp_public.go

@dymurray @pranavgaikwad I'd like to review&confirm if expected analysis results is correct, thanks!

Open questions for the analysis results approval:

aufi added a commit to aufi/go-konveyor-tests that referenced this issue Sep 22, 2023
Re-enabled check of Analysis Tags and updated expected Tags with their
Category.

Updated error outputs for better readability.

Related to konveyor#31

Signed-off-by: Marek Aufart <maufart@redhat.com>
@mguetta1
Copy link
Collaborator

https://issues.redhat.com/browse/MTA-1283

@aufi aufi self-assigned this Sep 27, 2023
@aufi
Copy link
Member

aufi commented Oct 12, 2023

Basic TestAppPublic analysis test (just source) is now part of TIER0 and works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants