Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 removing testcase that finds the target, because we no longer create #102

Merged
merged 2 commits into from
Mar 12, 2024
Merged

🐛 removing testcase that finds the target, because we no longer create #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbcb502
removing testcase that finds the target, because we no longer create …
shawn-hurley Mar 11, 2024
144a6e1
fixup
shawn-hurley Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions analysis/tc_tackle_testapp_public.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var TackleTestappPublic = TC{
},
Identities: []api.Identity{},
Analysis: api.Analysis{
Effort: 9,
Effort: 8,
Issues: []api.Issue{
{
Category: "mandatory",
Expand All @@ -35,12 +35,6 @@ var TackleTestappPublic = TC{
RuleSet: "discovery-rules",
Rule: "hardcoded-ip-address",
Incidents: []api.Incident{
{
File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
Line: 2,
Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
},
{
File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
Line: 2,
Expand Down
14 changes: 4 additions & 10 deletions analysis/tc_tackle_testapp_public_deps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var TackleTestappPublicWithDeps = TC{

},
Analysis: api.Analysis{
Effort: 3,
Effort: 2,
Issues: []api.Issue{
{
Category: "mandatory",
Expand All @@ -33,12 +33,6 @@ var TackleTestappPublicWithDeps = TC{
RuleSet: "discovery-rules",
Rule: "hardcoded-ip-address",
Incidents: []api.Incident{
{
File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
Line: 2,
Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
},
{
File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
Line: 2,
Expand All @@ -55,9 +49,9 @@ var TackleTestappPublicWithDeps = TC{
Rule: "local-storage-00001",
Incidents: []api.Incident{
{
File: "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java",
Line: 14,
Message: "\n An application running inside a container could lose access to a file in local storage",
File: "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java",
Line: 14,
Message: "\n An application running inside a container could lose access to a file in local storage",
},
},
},
Expand Down
8 changes: 1 addition & 7 deletions analysis/tc_tackle_testapp_public_package_filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ var TackleTestappPublicPackageFilter = TC{
},
},
Analysis: api.Analysis{
Effort: 2,
Effort: 1,
Issues: []api.Issue{
{
Category: "mandatory",
Expand All @@ -43,12 +43,6 @@ var TackleTestappPublicPackageFilter = TC{
RuleSet: "discovery-rules",
Rule: "hardcoded-ip-address",
Incidents: []api.Incident{
{
File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
Line: 2,
Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
},
{
File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
Line: 2,
Expand Down
Loading