Fix private binary app analysis tier3

[aufi]

Updating expected incidents files prefix and adding more readable diff for issues and incident lists.

This should fix tier3 test.

[aufi]

@pranavgaikwad @mguetta1 There is one incident less (than expected) for local-storage-00001, is it some known analyzer/test update?

  File:     "/bin/maven/java-project/src/main/java/io/konveyor/demo/config/ApplicationConfiguration.java",
  Line:     37,

[aufi]

It is with https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_tackle_testapp_private_binary.go#L47-L56 test expectation, the first incident in the file on line 8 is found, but not the other one that should be on line 37

(note, this application looks to be slightly different to tackle-testapp from github https://github.com/konveyor/tackle-testapp-public or https://github.com/konveyor/tackle-testapp)

[aufi]

It is with https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_tackle_testapp_private_binary.go#L47-L56 test expectation, the first incident in the file on line 8 is found, but not the other one that should be on line 37

(note, this application looks to be slightly different to tackle-testapp from github https://github.com/konveyor/tackle-testapp-public or https://github.com/konveyor/tackle-testapp)

Confirmed with @pranavgaikwad that the incident on line 37 is not recognized intentionaly after analyzer/rules change. Analysis in tier3 test now works for me.

...
--- PASS: TestApplicationAnalysis (245.22s)
    --- PASS: TestApplicationAnalysis/tackle-testapp-binary (245.22s)
PASS
ok  	github.com/konveyor/go-konveyor-tests/analysis	245.237s

[aufi]

TIER2 is expected to fail.

[aufi]

@pranavgaikwad Good point, updated, example:

...
    analysis_test.go:213: Different amount of incidents error. Got 8, expected 7.
Unexpected incident found: /bin/maven/java-project/src/main/java/io/konveyor/demo/config/ApplicationConfiguration.java line 8.

[mguetta1]

Hi @aufi
Should this change be backported into release-0.3?