Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 update for new ruleset changes #116

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

pranavgaikwad
Copy link
Contributor

@pranavgaikwad pranavgaikwad commented Apr 18, 2024

This is for changes to rulesets here konveyor/rulesets#71

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, re-run tests when ruleset update gets in.

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad merged commit 3a1bb74 into konveyor:main Apr 25, 2024
3 of 5 checks passed
@mguetta1
Copy link
Collaborator

mguetta1 commented Apr 30, 2024

Hi @pranavgaikwad @aufi
TIER3 binary analysis failed on:
09:37:43 analysis_test.go:293: Different Tags amount error. Got: 9, expected: 6.
https://main-jenkins-csb-migrationqe.apps.ocp-c1.prod.psi.redhat.com/view/MTA/job/mta/job/konveyor-go-tests-pr-tester/job/main/50/console

Could you please take a look and update if the expected results should be updated?
Thanks!

@mguetta1
Copy link
Collaborator

@fbladilo uses release-0.3 branch to run against 7.0 d/s builds, please cherry-pick this PR if needed

aufi added a commit to aufi/go-konveyor-tests that referenced this pull request May 2, 2024
There was an update in rulesets with update of upstream tests
in konveyor#116

Updating tier3 tests according to ^

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi aufi mentioned this pull request May 2, 2024
aufi added a commit that referenced this pull request May 2, 2024
There was an update in rulesets with update of upstream tests
in #116

Updating tier3 tests according to ^

Signed-off-by: Marek Aufart <maufart@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants