Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Replace Upload binary test #123

Merged
merged 8 commits into from
May 26, 2024

Conversation

nachandr
Copy link
Contributor

@nachandr nachandr commented May 9, 2024

We don't always get consistent results with the current application being used for analysis. This has been reported in
Bug MTA-2606 .
So, I'm replacing the existing upload binary test with this PR. The new test uses the acmeair-webapp binary for analysis .
The same app is used in the UI tests as well.

Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
@nachandr nachandr changed the title [WIP] Upload binary - acmeair-webapp [WIP] Replace Upload binary test May 10, 2024
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nachandr for the PR!
Please see comments

analysis/tc_upload_binary.go Outdated Show resolved Hide resolved
analysis/tc_upload_binary.go Outdated Show resolved Hide resolved
analysis/tc_upload_binary.go Outdated Show resolved Hide resolved
analysis/tc_upload_binary.go Outdated Show resolved Hide resolved
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, requesting changes mentioned by @mguetta1

@nachandr
Copy link
Contributor Author

On MTA 7.0.3-25, I noticed that 'Effort' and 'Tags' show zero after successful analysis of binary applications .
I reported bug MTA-2821 yesterday so that issue could be addressed.

@nachandr
Copy link
Contributor Author

nachandr commented May 17, 2024

  1. I tested several applications. I continue to see inconsistent values for Effort, Tag count, Issue count, Dependency count between upstream and downstream builds (MTA 7.0.3) .

I did the development and testing on d/s.

  1. Additionally, I see inconsistent values when app analysis is done on UI and through API on d/s build (MTA 7.0.3).

@mguetta1
Copy link
Collaborator

Thanks @nachandr
Please move it to TIER2 for now

Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
@nachandr nachandr changed the title [WIP] Replace Upload binary test [RFR] Replace Upload binary test May 22, 2024
@nachandr
Copy link
Contributor Author

  1. I tested several applications. I continue to see inconsistent values for Effort, Tag count, Issue count, Dependency count between upstream and downstream builds (MTA 7.0.3) .

The different results for 7.0 and 7.1 (latest upstream) are expected . So, the plan is to submit 2 PRs with different expected output , one for main and the other for release-0.3 which corresponds to MTA 7.0.3.

@nachandr
Copy link
Contributor Author

Results from PR tester run

  1. I added a new TIER0 test and all the tier0 tests are passing
  2. One of the TIER2 tests is failing because of bug MTA-2606 ,

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguetta1 mguetta1 merged commit 2423c5b into konveyor:main May 26, 2024
4 of 5 checks passed
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this pull request Jun 2, 2024
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this pull request Jun 27, 2024
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
sshveta pushed a commit that referenced this pull request Jun 28, 2024
* Moving Tomcat analysis TC to TIER0 (#125)

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>

* [RFR] Replace Upload binary test  (#123)

Signed-off-by: Nandini Chandra <nachandr@redhat.com>

* Updating Tomcat analysis results

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>

---------

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Co-authored-by: Nandini Chandra <nachandr@redhat.com>
msajidmansoori12 pushed a commit to msajidmansoori12/go-konveyor-tests that referenced this pull request Jul 9, 2024
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants