-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Replace Upload binary test #123
Conversation
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nachandr for the PR!
Please see comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR, requesting changes mentioned by @mguetta1
On MTA 7.0.3-25, I noticed that 'Effort' and 'Tags' show zero after successful analysis of binary applications . |
I did the development and testing on d/s.
|
Thanks @nachandr |
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
The different results for 7.0 and 7.1 (latest upstream) are expected . So, the plan is to submit 2 PRs with different expected output , one for main and the other for release-0.3 which corresponds to MTA 7.0.3. |
Results from PR tester run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
* Moving Tomcat analysis TC to TIER0 (#125) Signed-off-by: Maayan Hadasi <mguetta@redhat.com> * [RFR] Replace Upload binary test (#123) Signed-off-by: Nandini Chandra <nachandr@redhat.com> * Updating Tomcat analysis results Signed-off-by: Maayan Hadasi <mguetta@redhat.com> --------- Signed-off-by: Maayan Hadasi <mguetta@redhat.com> Signed-off-by: Nandini Chandra <nachandr@redhat.com> Co-authored-by: Nandini Chandra <nachandr@redhat.com>
Signed-off-by: Nandini Chandra <nachandr@redhat.com>
We don't always get consistent results with the current application being used for analysis. This has been reported in
Bug MTA-2606 .
So, I'm replacing the existing upload binary test with this PR. The new test uses the acmeair-webapp binary for analysis .
The same app is used in the UI tests as well.