Introduce test tiers #21
Conversation
To provide maximum information about the project functionality, tests exections were separated into three stages (0,1,2). From core functionality to nice to haves. Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
|
Stage1 target depends on #16 |
|
@aufi This looks good to me, were there any tests that needed to be dropped or are we at test parity with the old analyzer now? |
Makefile
Outdated
| test-all: test-analysis | ||
| # Metrics. | ||
| test-metrics: | ||
| HUB_BASE_URL="http://${MINIKUBE_IP}/hub" go test -count=1 -v ./metrics/... |
There was a problem hiding this comment.
@aufi could you please use ginkgo command here to enable relevant test info
HUB_BASE_URL="http://${MINIKUBE_IP}/hub" ginkgo -v ./e2e/metrics/...
There was a problem hiding this comment.
Sure! Will update once PR #16 gets merged (ginkgo command is not yet included in repo).
Makefile
Outdated
|
|
||
| # Stage1 - all normal features expected to work. | ||
| test-stage1: | ||
| STAGE1=1 $(MAKE) test-analysis |
There was a problem hiding this comment.
Is it necessary to execute tests included in earlier stage?
There was a problem hiding this comment.
Good question, from my point of view it is no, but I'm happy discuss pros and cons.
Signed-off-by: Marek Aufart <maufart@redhat.com>
@fabianvf We had just few tests from past on analysis (Pathfinder example-1 app and Petclinic). Currently Petclinic w/hazelcast is not included in analysis test - will be added (in one of next PRs). |
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Tests execution
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi
force-pushed
the
add-test-stages
branch
from
ff36f13
to
110eef1
Compare
Signed-off-by: Marek Aufart <maufart@redhat.com>
|
Merging with passing tier0. |
To provide maximum information about the project functionality, tests exections were separated into three tiers (stages) 0,1,2. From core functionality to nice to haves.
Updated github workflows, Makefile targets and README with description.