Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ginkgo test: Unlink application from Jira #94

Merged
merged 11 commits into from
Feb 19, 2024
Merged

Ginkgo test: Unlink application from Jira #94

merged 11 commits into from
Feb 19, 2024

Conversation

mguetta1
Copy link
Collaborator

Test setup:

  • Create app, Jira connection and migration wave.
  • Export app to Jira instance.

Test steps:

  1. Delete Jira instance --> should fail because there is an issue associated with an application
  2. Delete ticket --> ticket successfully deleted and Jira instance can be removed

The test fails on the first step due to https://issues.redhat.com/browse/MTA-2226

Related to #14

@sshveta
Copy link
Collaborator

sshveta commented Feb 15, 2024

According to comment on bug 2226 , JIRA instances can be deleted even if issues exists . First test should pass now.

@mguetta1
Copy link
Collaborator Author

mguetta1 commented Feb 18, 2024 •
edited
Loading

According to comment on bug 2226 , JIRA instances can be deleted even if issues exists . First test should pass now.

In that case, there is no reason to merge this test
Ticket CRUD test is already coverd in tackle2-hub repo:
https://github.com/konveyor/tackle2-hub/blob/main/test/api/ticket/api_test.go

cc: @aufi

@mguetta1
Adding Jira CheckConnection() and Slice of Jiras
bd788c7 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Using Golang varieble as argument in export test
3f606e9 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Fixing panic error
30854ea 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Adding func that checks ticket.Reference is not empty
c0c6439 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Refactoring variable names
d91f233 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Ginkgo test: Unlink application from Jira
8d1dd9d 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Minor changes
3730f49 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Checking ticket.Reference field in test file
2c238c8 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Update README
654ef78 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Removing unused vars
41f15ff 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Deleted e2e/migrationwave/unlink_application.go
74f0295 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@aufi aufi closed this Feb 19, 2024
@aufi aufi reopened this Feb 19, 2024
aufi
aufi approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@aufi aufi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an overlapping with basic crud test in hub API as a problem, LGTM.

(sorry for close/reopen, did a wrong click)

@mguetta1 mguetta1 merged commit 97d086f into konveyor:main Feb 19, 2024
6 of 9 checks passed
@mguetta1 mguetta1 deleted the mw-unlink-app branch March 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aufi aufi aufi approved these changes

@sshveta sshveta sshveta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mguetta1 @sshveta @aufi