Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): treat axios properly as an external peer dependency #25

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Oct 7, 2020

Currently axios is both installed as a real dependency and listed as a peerDependency the consumer must install themselves. I only intended the latter (because it is included in rollup's peerDepsExternal plugin, it doesn't actually need to be bundled).

It is still needed at build time for TS types and such, so this moves it into devDependencies.

@mturley mturley requested a review from a team October 7, 2020 18:18
@konveyor-preview-bot
Copy link

🚀 Deployed Storybook Preview: http://konveyor-lib-ui-pr-25-preview.surge.sh

@ibolton336 ibolton336 merged commit b474a04 into migtools:master Oct 7, 2020
@konveyor-release-bot
Copy link

🎉 This PR is included in version 1.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants