Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2062266: removing duplicate pods in logs list and fixing bug 2062266 partially #1301

Merged
merged 1 commit into from May 16, 2022
Merged

Bug 2062266: removing duplicate pods in logs list and fixing bug 2062266 partially #1301

merged 1 commit into from May 16, 2022

Conversation

JaydipGabani
Copy link
Contributor

No description provided.

jmontleon
jmontleon approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JaydipGabani, jmontleon

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaydipGabani JaydipGabani changed the title Bug-2062266: removing duplicate pods in logs list and fixing bug 2062266 partially Bug 2062266: removing duplicate pods in logs list and fixing bug 2062266 partially May 16, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@JaydipGabani: This pull request references Bugzilla bug 2062266, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ssingla@redhat.com), skipping review request.

In response to this:

Bug 2062266: removing duplicate pods in logs list and fixing bug 2062266 partially

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JaydipGabani JaydipGabani merged commit 142b1fb into migtools:master May 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@JaydipGabani: All pull requests linked via external trackers have merged:

Bugzilla bug 2062266 has been moved to the MODIFIED state.

In response to this:

Bug 2062266: removing duplicate pods in logs list and fixing bug 2062266 partially

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JaydipGabani added a commit to JaydipGabani/mig-controller that referenced this pull request May 16, 2022
@JaydipGabani
removing duplicate pods in logs list and fixing bug 2062266 partially (…
034b46d 
…migtools#1301)
JaydipGabani added a commit that referenced this pull request May 23, 2022
@JaydipGabani
Cherry-pick: removing duplicate pods in logs list and fixing bug 2062…
346979c 
…266 partially (#1302)

* removing duplicate pods in logs list and fixing bug 2062266 partially (#1301)

* looking for common velero pod label to find velero pods (#1303)

(cherry picked from commit 2260828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmontleon jmontleon jmontleon approved these changes

@ibolton336 ibolton336 Awaiting requested review from ibolton336

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@jmontleon jmontleon

Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JaydipGabani @jmontleon