Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2062862: Check for errors in promise.all call and allow partial failure #1435

Merged
merged 4 commits into from Jun 6, 2022

Conversation

ibolton336
Copy link
Contributor

@ibolton336 ibolton336 commented Jun 3, 2022

Bugzilla bug 2062862 Allow secret ref api call to fail while still returning a found cluster from within the cluster poll saga.

Screen Shot 2022-06-03 at 11 53 30 AM

Screen Shot 2022-06-03 at 11 54 47 AM

@ibolton336 ibolton336 requested a review from a team June 3, 2022 15:47
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@ibolton336: This pull request references Bugzilla bug 2062862, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to this:

Bug 2062862: Check for errors in promise.all call and allow partial failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@ibolton336: This pull request references Bugzilla bug 2062862, which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to this:

Bug 2062862: Check for errors in promise.all call and allow partial failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@ibolton336: This pull request references Bugzilla bug 2062862, which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to this:

Bug 2062862: Check for errors in promise.all call and allow partial failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@ibolton336: This pull request references Bugzilla bug 2062862, which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to this:

Bug 2062862: Check for errors in promise.all call and allow partial failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibolton336, mturley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley mturley merged commit bb9cf90 into migtools:master Jun 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2022

@ibolton336: All pull requests linked via external trackers have merged:

Bugzilla bug 2062862 has been moved to the MODIFIED state.

In response to this:

Bug 2062862: Check for errors in promise.all call and allow partial failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rayfordj pushed a commit to rayfordj/mig-ui that referenced this pull request Jun 8, 2022
…ailure (migtools#1435)

* Check for errors in promise.all call and allow partial failure

* cleanup

* cleanup

* Change from string to undefined to match storage implementation
mturley pushed a commit that referenced this pull request Jun 9, 2022
…ailure (#1435) (#1443)

* Check for errors in promise.all call and allow partial failure

* cleanup

* cleanup

* Change from string to undefined to match storage implementation

Co-authored-by: Ian Bolton <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants