Bug 2038898: Add valued update check for aws s3/s3 repo type #1436
Conversation
openshift-ci
bot
added
bugzilla/severity-low
|
@ibolton336: This pull request references Bugzilla bug 2038898, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 2 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
|
|
||
| const valuesHaveUpdate = (values: any, currentStorage: IStorage, isAWS: boolean) => { |
There was a problem hiding this comment.
This is fine because it's the pattern we've established, but it has me wondering if we could use Formik better for this kind of thing. Isn't this what the isDirty property in form state is supposed to be for? Might be worth looking into why we didn't use that in the past (I suspect something to do with prefilling asynchronously, that's why I ended up adding a prefill function to useFormState)
There was a problem hiding this comment.
100% agree. Would definitely be worth a revisit. With forms with multiple conditional fields, I wonder the best approach for properly using the isDirty prop. We might have to split out the s3 /aws s3 forms into their own forms.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibolton336, mturley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ibolton336: All pull requests linked via external trackers have merged: Bugzilla bug 2038898 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.7.2 |
|
@rayfordj: only konveyor org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…s#1436) * Add valued update check for aws s3/s3 repo type * cleanup
|
/cherry-pick release-1.7.2 |
|
@jmontleon: only konveyor org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.7.2 |
|
@kaovilai: new pull request created: #1451 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=2038898