Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2056962: For non-SCC intra-cluster migrations, don't allow target namespace to equal source namespace #1439

Merged
merged 2 commits into from Jun 15, 2022

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Jun 6, 2022

@mturley mturley requested a review from a team June 6, 2022 16:49
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2022

@mturley: This pull request references Bugzilla bug 2056962, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to this:

Bug 2056962: For non-SCC intra-cluster migrations, don't allow target namespace to equal source namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 6, 2022
@mturley mturley force-pushed the bz2056962-state-same-namespace branch from b38f93d to 6af9d76 Compare June 6, 2022 17:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@ibolton336
Copy link
Contributor

LGTM 👍

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibolton336, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 186cc4f into migtools:master Jun 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2022

@mturley: All pull requests linked via external trackers have merged:

Bugzilla bug 2056962 has been moved to the MODIFIED state.

In response to this:

Bug 2056962: For non-SCC intra-cluster migrations, don't allow target namespace to equal source namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mturley mturley deleted the bz2056962-state-same-namespace branch June 16, 2022 17:10
mturley added a commit to mturley/mig-ui that referenced this pull request Jun 16, 2022
… namespace to equal source namespace (migtools#1439)

Co-authored-by: Ian Bolton <ibolton@redhat.com>
openshift-ci bot pushed a commit that referenced this pull request Jun 17, 2022
… namespace to equal source namespace (#1439) (#1456)

Co-authored-by: Ian Bolton <ibolton@redhat.com>

Co-authored-by: Ian Bolton <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants