Bug 2058172: Add plan status icon update for succeeded rollback #1447
Conversation
openshift-ci
bot
added
approved
|
@ibolton336: This pull request references Bugzilla bug 2058172, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 2 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
| @@ -82,6 +84,12 @@ const PlanStatusIcon: React.FunctionComponent<IProps> = ({ plan }) => { | |||
| <ResourcesAlmostEmptyIcon /> | |||
| </span> | |||
| ); | |||
| } else if (latestAction === 'rollback' && hasSucceededCondition) { | |||
There was a problem hiding this comment.
@ibolton336 you're gonna kill me, but I double checked and there is already a hasSucceededRollback on the plan?.PlanStatus that you can use instead of this line, just like hasSucceededStage and hasSuccededCutover above. See https://github.com/konveyor/mig-ui/blob/master/src/app/plan/duck/selectors.ts#L189-L198
I think that's actually more accurate than this because hasSucceededCondition is based on conditions on the plan and not the migration (I'm not sure if the plan gets a success condition when a rollback succeeds but the rollback's migmigration definitely does)
There was a problem hiding this comment.
My thought process here was ok.. maybe there was a succeeded rollback somewhere in the Migration history. But maybe that would be falsely triggered if they re run a migration after the said rollback. I need to look back again and see if that is a valid concern. Wanted to make sure the latest action was a rollback before showing that message. Does that make sense?
There was a problem hiding this comment.
Oops, I see that hasSucceededRollback checks that the latest action is a rollback.
There was a problem hiding this comment.
yeah it's not the best naming :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibolton336, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ibolton336: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2058172 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=2058172