Bug 1818021 - Implement observedDigest #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknelson
changed the title
eriknelson
suggested changes
Apr 28, 2020
src/app/plan/duck/sagas.ts
Outdated
| if (isRerunPVDiscovery) { | ||
| const updatedGeneration = updatedPlan.status.observedDigest; | ||
| const oldGeneration = currentPlan.status.observedDigest; | ||
| if (updatedGeneration === oldGeneration) { |
There was a problem hiding this comment.
Can we update each of these return paths with a comment that describes the specific case?
ibolton336
force-pushed
the
wizard-refactoring
branch
from
4dca6fa
to
6feb51e
Compare
|
I've tested this on 3->3 and 3->4 migrations and had good success with both, this even repairs a number of edit problems we've had previously:
Really happy to see this come together, thank you @ibolton336! Want to follow up on the comments because I'm having a hard time following but I think this is looking good. |
eriknelson
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1818021
Closes #781